system-bt

Fork

Bluetooth: Fix to decrease power during OPP TX/RX

Refactor the original Fix.
Used 1000 milli second instead of 1 second, as API
changed to millisecond.

Change-Id: I0ecac707751f990eeabc63e56ad79e54b06e7a73
CRs-Fixed: 1036350

Bluetooth: Gap: Adding NULL check in HAL interface

When the HCI_RAW_CMD support is included, adding
NULL check for bt_hal_cbacks and hci_event_recv_cb
in btif_hci_event_cback to avoid ASSERT message
continuosly which is consuming more power.

CRs-Fixed: 922611
Change-Id: I995e6411012fe515ca725267045a97076b692b7d

BT: ACL and l2c out if sync after connection collision

Problem: Remote device can't be removed from paired list.
Cause: After connection collision, lcb is removed after
connection request is rejected by soc but acl entry is not
removed. So, for upper layer, acl connection always remains
up.
Fix: Removed acl connection and acl entry when connection
complete is received and lcb is not present.

CRs-Fixed: 987968
Change-Id: Ie2049217e436704262f06d0c0dc51611697cc29a

Bluetooth: GAP: Accept incoming connection in slave role

Accept incoming connection in slave role for blacklisted remotes

Change-Id: I7acda5f794fa53dd270b31c048f5e85a0ed7ce94
CRs-Fixed: 943689

SDP: Restricted invalid attr len in sdp delete

Restricted invalid attr len in SDP_DeleteAttribute as
pointer is trying to access invalid memory when attr_len
is invalid

Registering PNP record before PAN profile as PNP record
should be registered before profiles.In some cases PAN and
PNP SDP registration colliding and leading to memory
corruption in SDP DB.

Change-Id: Ib6d2120c7ef1d10633fa905d6b853281efaf0ecd

Bluetooth: Cleanup ACL link during restarting pending ACL connection

This fix removes the previously held ACL link with the BR_EDR
device before trying to create a new pending connection with the
same device.

Change-Id: Iac941794e2fc86c48781edc86492146ab5c21eae

Bluetooth: Cleanup the lcb variables properly on reuse

- Cleanup all relevant link control block variables
like send_not_acked, partial_segment_being_sent
and stop the info response timer to reuse the same
LCB.

- L2cap layer will reuse the same lcb if the link is
disconnected and wants to re-establish the link.

Change-Id: I822b0ee350574bbeb5b3c86a349d1471fa45761a

Change-Id: I15f83b5c1a88d248d29080123ebbf4652f2cb340
CRs-Fixed: 885782

Bluetooth: Dont initiate rnr from pinreq if rnr in progress

Dont initiate rnr from pinreq if rnr from security module is
in progress

Change-Id: I129044dca030bcf28495c30f4536bda5936e79a2
CRs-Fixed: 944764

Bluetooth: Use correct transport to check ACL connection

This change corrects the transport type used to verify if
the ACL connection for LE exists for a specific bda during
the cancel connection routine. This cancel connection routine
is triggered by advertiser connection complete, if the connection
to the same remote is pending as a scanner as well.
The process above leads to connection cancel and releasing the
link blocks. The correct check used in this change prevents the
release of link block due to the connection cancel.
Also, safety check has been added to the LE notification
routine to prevent the use of link blocks if it does not exist

CRs-Fixed: 1033641
Change-Id: If2f923e6a39974f01c62f1cbdbca6372a3082821

Revert "Fix bug where a bonded device could enter BONDING and BONDED states again."

This reverts commit 0b7fc589089ce4a96daa668b9d293ce01982424d.

Conflicts:
btif/src/btif_dm.c

CRs-Fixed: 1033628
Change-Id: I1b7ccf0ff4eaebe1c947ee81e50e4587a1bdbb47

Bluetooth: Prevent multiple register of service change indication

Use Case:
Pair DUT to a remote LE device. The host registers for the service
change indication twice, once when the connection callback is
received and another time, when the SMP process completes

Failure:
There are a few issues caused by this.
First, the duplicate action of service change indication registeration
is unnecessary.
The registeration that follows the SMP process adds a gatt_if to the
apps holding the current link. This gatt_if (=1) never disconnects
after registeration failure or success. And hence the host can never
physically disconnect the link.

Fix:
This change removes the service change registeration at SMP
process completion

CRs-Fixed: 1033611
Change-Id: I0d7566e2b4a9d01aa7926cdbe9f528c3941fcfeb

Bluetooth: Do not go for inquiry in BONDING State

This patch fix a special case where DUT is paired & connected
with only one device, which has capbility to intiate paring as
soon as DUT unpair same remote device. As DUT is paired with
only one device, In this case Once DUT unpair remote device. DUT
goes for inquiry & at same time remote device initiates pairing
if Bludroid stack recieve pairing request before the inquiry
start then DUT should not go for inquiry, As DUT is already in
BONDING state.

CRs-Fixed: 481263

Change-Id: I0e1ec0fdb963921629e5c52f495ae2013e679a03

SDP: Fix for SDP query in certification test with Invalid PduSize

Bluedroid stack is only checking parameter length and input data length.
Added an extra logic to handle invalid data after getting last valid data.

Change-Id: I47eafb2c24e73b472c31a2fb47e02d48c5e04f6c

CRs-Fixed: 491693

Bluetooth: GAP: Update name as part of Discovery of services

Update the remote device name to upper layers as part of
discovery of remote device services.

CRs-Fixed: 593306

Change-Id: I24d899c1f5ccc81d8b0c4257abae16a7bf5d4682

Bluetooth: Handled delayed info rsp from remote during SDP

DUT initiates connection with out waiting for information response
from remote device during SDP.

Change-Id: Iee0251f8f81923b1291983b66b31c78e14d21af0

CRs-Fixed: 635697

Bluetooth: GAP: Changing the security to general bonding

Changing the security from non bonding to general bonding
in BTM_SEC_OUT_AUTHENTICATE condition.

Change-Id: I65d2ec4466e2bd81df2cc7e2936e05159a8645ed

CRs-Fixed: 676532

Bluetooth: Store local and remote io caps before RNR

Stores the loc_io_caps nad rmt_io_caps when the remote
name request is called, and these will be retrieved
in the function bta_dm_pinname_cback.

CRs-fixed: 535245

Change-Id: I4b2156d7101acabb1ded65bd21d49a9c4551f8db

Bluetooth: GAP: Handle security failure with invalid handle

Return NULL incase of invalid handle when finding a device
based on the handle. This will make sure to avoid giving
a invalid entry from the device list.

Also send authentication failure in case of invalid handle.

Change-Id: Ia95d10ae95cfa1750386233ee90f01899061294e

CRs-Fixed: 592545

Change-Id: I71b902ae201e32a0fb18fd3bce52fd86e8cbcdd5
CRs-Fixed: 902577

Fix for Compilation Issue

We build our system/bt code by setting BLUETOOTH_QTI_SW macro always to TRUE.
But Customer wants to build by setting BLUETOOTH_QTI_SW macro to FALSE,
Which leads to compilation Issue.When SCO open was initiated by AG
and failed for mSBC,then Fallback to CVSD settings which has not done in
else condition.
So, we should add falling back to CVSD in else condition.

CRs-Fixed: 1031600
Change-Id: I7ed33cc20374dd899b21e3fa12abe622ddc84eff

Fixes for Static analysis tool reported.

CRs-Fixed: 1028649
Change-Id: If86dc1766f225a097e4dcdcb68bf6ea6bec50a2a

Bluetooth: Modify logic to ignore HID notifications

This change reverts the previous logic and delays the
ignoring of indications for HID devices, after the processing
of service change indications.
This is needed for keeping the update count equal to the
number of apps registered, so that service change indications
can be properly confirmed and followed by remote service
discovery.
This reverts commit a85bd580013944b321d88c3c5515a015c9f67f72.
CRs-Fixed: 982471

Change-Id: Iabba84aac1af6847bb44fd2169bd0870d8d14a55

Bluetooth: Increased the command buffer length to 128.

Increased the command buffer length to 128.
In align with the incoming buffer size.

Change-Id: I2dba02a4c5b40925b4d9ddcd2babd432859e93b6
CRs-Fixed: 973303

AG: Accept '-' character in dial number string.

Some Headsets storing Number from CLCC response and sending
ATD<number with special Char '-'> for redial.We do not accept
special char '-' in number string and sending Error reponse.
We should add check for accept this special char '-' in
string for redial.

CRs-Fixed: 1031997
Change-Id: I7dfc6c98fdd902361e40752b10d0c41d7ca8fe7b

BT: Rectify size passed to copy service name to secu records

Use case: Services having name length greater than max lenght
always take new slot in security records. So, after few enable
disable cycles in BLE ON scenario, the record gets completely
occupied making further connection impossible.

Steps:
1. Install a BLE App to create BLE always ON scenario.
2. Run a few cycles of Bluetooth(bredr) enable-disable.

Failure: Once security records are completely occupied, new
connections are not possible because of socket creation
failure due to unavailability of security id.

Root cause: Size passed to copy service name does not include
bit for null termination. So, for services having name size
greater than that size have their last bit truncated for null
termication. So, during next enable, the comparision with
same size always fails causing service to take new slot in
security records array.

Fix: Increased the size passed to copy service name by 1 after
considering null termination.

Change-Id: I3527df6610932f60fd85bcdd14d5b8a527c79722
CRs-Fixed: 1026359

Bluetooth: GAP: Reject incoming pairing if already in progress

- This patch properly rejects incoming pairing request from remote device
if already in pairing state. Without this patch it was observed that in
some corner cases pairing was auto accepted for remote device while
pairing was in progress with another remote device leading to inconsistent
behaviour.

Change-Id: I19a2a98e4ceb51cabaef279a2e3f8224fbed9ea1
CRs-Fixed: 1032165

Bluetooth: Fix to decrease power during OPP TX/RX

Due to alarm timer implementation, bta_sys_idle OR bta_sys_busy call
was the overhead(eg. 7ms) on every OPP packet(TX/RX), which was causing
high power. Below optimization have been done in JV to decrease
power during OPP TX/RX
- If particular JV acl link is in sniff, only then use bta_sys_busy to
trigger unsniff request.
- Start intermediate idle timer(1s) before starting actual idle sniff
timer(bta_sys_idle).

CRs-fixed: 1028625
Change-Id: Ied1173776f9bf2dc89b8e84e68d6217932a01607

BT: Checking for stack status before removing sdp

Based on appliaction implementation, this api
can be called during undesirable state like
when stack is being cleared. This causes ANR
and tombstone in Bluetooth.
Checked for status of stack and returned without
processing if stack is already cleared.

Change-Id: Ib5447402f9c28e010a74700927be54db44f9ca65
CRs-Fixed: 975088

Use Local ccb variable in loop to check GAP CCB pool

File Receiving fails on DUT after 3 file transfers using OOL from DUT.

steps:
Transfer the files between two devices which supports OOL after pairing.
After 3 files transfer from DUT, send a file from remote to DUT.
File transfer fails.

Failure: File transfer from remote to DUT fails always after 3 opp
client connections

Root cause: File transfer is failing always because no RCB's available.
RCB's were not cleaned up after use.

FIX: RCB's were not cleaned up because there is an extra check has been
added with transpo for the CCB.And wrong CCB is passed to check transport
to clean up.Using another local variable for the p_ccb will solve the issue.

Change-Id: I06a8f237047ffb212118b4239e9856fe5c89acb1

HID:PAN: Fix issues reported by Static Analysis Tool

Fix issues reported by Static Analysis Tool.

CRs-Fixed: 1025718
Change-Id: Ie0347307d7536f18bf8f32a2dfeda593a41933bf

Delete GATT cache file from NVRAM when device is unpaired

GATT cache file is created for each remote device when
service discovery is performed. This file is not removed
when a device is unpaired. Hence even after performing a
fresh pairing, the subsequent service discoveries end up
retrieving the attribute list from the GATT cache instead
of fetching the results over the air.

The service discoveries for non paired devices also are
not performed over the air for the reconnection attempts.

This change deletes the GATT cache NVRAM file when a device
is unpaired and also resets the GATT cache structures
during disconnection of non paired devices.

Change-Id: I35ec4d0a53820c671fe94cb83927548b9be53d28

Bluetooth: Select bluetooth transport dynamically

Select bluetooth transport dynamically on the basis of
qcom.bluetooth.soc property. This patch removes the use of board
configuration option QCOM_BT_USE_SMD_TTY and uses dynamically
detected SOC type to choose required transport.

Change-Id: Iae1ee900362af95c42bffcc444b56267cbbae92d

Bluetooth: Select bluetooth HCI driver dynamically

Select bluetooth HCI driver dynamically on the basis of
qcom.bluetooth.soc property. This patch removes the use of board
configuration option BLUETOOTH_HCI_USE_MCT and uses dynamically
detected SOC type to choose required HCI driver.

Change-Id: Idecb2fd74fbc9d361c2877e9b3a47606667e0229

Revert "Revert "Initial commit for rfcomm test tool""

Added strict_mode boolean parameter in enable function.

This reverts commit 007093f5aded6eb02501602996e2f2883b3923c7

Change-Id: I37a282e80fa6e884fbdf51de283d3e9c2761a7c4
CRs-Fixed: 1014526

Btsnoop write from external process

- Write btsnoop from external process
Introduced a new proces to dump snoop packets into file.
Snoop packet can be send to the remote process using local
socket as writing to file from BT process can cause A2DP
choppyness.

- Avoid btsnoop file write if btsnoop client is connected
Existing implementation writes it to file though the packet is
sent over network socket. This chnage will make sure to avoid
writing it to file if any of the network/local socket is
connected.

- Generalized the mechanism to use same code irrespective of
what type of socket it is. Otherwise having thread for each
socket is not preferrable.

- Adjust the GMT offset to match with logcat logs.

- Limit the block of snoop write to 10ms and drop the packet.

- Memcpy issue single write to eliminate multiple I/O.

- Enable snoop by default on userdebug build.

- Option to override snoop config for userdebug build.

Change-Id: I13749dc348baf88af57e3ebec1ec7acd5e999c04

HID: Add support for set report and get report

Add support for set report and get report in HID user
space because of changes in uhid kernel driver with kernel changes
for kernel 3.18. Without these changes issues are seen with hid devices
that uses vendor usb hid drivers and send specific set and get report
to hid devices for their proper functioning.

Following are the new flags added in uhid driver of kernel, for which
support is required in hid user space.

UHID_GET_REPORT
UHID_GET_REPORT_REPLY
UHID_SET_REPORT
UHID_SET_REPORT_REPLY

Also update __FUNCTION__ to __func__ in API's where changes are made.

Change-Id: I90230b76d68e9275dcacd9f46f03e312ddf2fa30
CRs-Fixed: 963213

Bluetooth: Disable eager reader threads in RX path

- Disabled eager reader threads in RX path for both
ROME and PRONTO targets.

- Exising machamisn is to poll for incoming data
(event, ACL data) using dedicated thread called
eager reader thread.

- Now the responsibility of polling for data moved
to existing HCI worker thread.

- Enhanced the read mechanism from hci hal interface.

CRsFixed: 934414
Change-Id: Icfd27b7b93f83033b2230e61a23df69aa3c33bdf

Bluetooth: Optimize the L2cap FCR tx timer

- Optimize the L2cap Flow control tx timer
to avoid frequent start and stop of same
timer.

- it will restart the timer instead of stop
and start.

- Changes made in btm timer functions also
to avoid scheduling of next timer in queue
though is not required as the same timer
is supposed to start.

CRsFixed: 934414
Change-Id: Idd43a71617a27c6d70fafa4e31c16f735a1a9425

Bluetooth: Handle the SSR timeout case properly

- Kill the bluetooth process in case of SSR timeout,
otherwise it will try to read the invalid data
that might lead to crash.

- Also corrected the data type to check when error
occurs on read call.

CRs-Fixed: 978009
Change-Id: I42f6c9f4a437f7b143fe1e1beb3b6ef39533f4d7

Bluetooth: Separated initialize and re-initialize of bta_dm_cb control block

-Added bta_dm_deinit_cb function to re-initialize of
bta_dm_cb control block

-Modified the condition to set disable timer in case of any active
ACL connections

Change-Id: I872944c39912bc8a534eba080a0ade7ced942bec
CRs-Fixed: 1025769

Set DUT role as slave for outgoing connection

Do not send role switch while accepting incoming connection
for Roman R9020 which delays responding to AVDTP_DISCOVER
and AVDTP_OPEN when in Slave role.

Change-Id: I1ba5bc0f1f88fe8ef7f4c186fbdfacd6726d3720