Commit: f8f4527ef9583947a69ad875e63148d73e23aabe - system-hardware-interfaces (git)

system/hardware/interfaces

Commit MetaInfo

• Revision: f8f4527ef9583947a69ad875e63148d73e23aabe (tree)
• Zeit: 2019-03-22 02:31:50
• Autor: Tri Vo <trong@goog...>
• Commiter: android-build-merger

Log Message

SystemSuspendTest.CleanupOnAbort increase timeout
am: 28d18ced6f

Change-Id: Ibc716da5ae4e2a99f346637a6a1d64dddd921c13

Ändern Zusammenfassung

• modified: suspend/1.0/default/SystemSuspendUnitTest.cpp

Diff

--- a/suspend/1.0/default/SystemSuspendUnitTest.cpp
+++ b/suspend/1.0/default/SystemSuspendUnitTest.cpp
@@ -65,11 +65,10 @@ namespace android {
 static constexpr char kServiceName[] = "TestService";
 static constexpr char kControlServiceName[] = "TestControlService";
 
-static bool isReadBlocked(int fd) {
+static bool isReadBlocked(int fd, int timeout_ms = 20) {
     struct pollfd pfd {
         .fd = fd, .events = POLLIN,
     };
-    int timeout_ms = 20;
     return poll(&pfd, 1, timeout_ms) == 0;
 }
 
@@ -168,7 +167,7 @@ class SystemSuspendTest : public ::testing::Test {
         ASSERT_TRUE(WriteStringToFd(wakeupCount, wakeupCountFd));
     }
 
-    bool isSystemSuspendBlocked() { return isReadBlocked(stateFd); }
+    bool isSystemSuspendBlocked(int timeout_ms = 20) { return isReadBlocked(stateFd, timeout_ms); }
 
     sp<IWakeLock> acquireWakeLock() {
         return suspendService->acquireWakeLock(WakeLockType::PARTIAL, "TestLock");
@@ -288,7 +287,9 @@ TEST_F(SystemSuspendTest, CleanupOnAbort) {
         ::testing::KilledBySignal(SIGABRT), "");
     ASSERT_TRUE(isSystemSuspendBlocked());
     unblockSystemSuspendFromWakeupCount();
-    ASSERT_FALSE(isSystemSuspendBlocked());
+    // Timing of the wake lock clean-up after process death is scheduler-dependent.
+    // Increase the timeout to avoid flakes.
+    ASSERT_FALSE(isSystemSuspendBlocked(200));
 }
 
 // Test that debug dump has correct information about WakeLocks.