Commit: 0752d3219e9d36746939f5dc0e0d595119025a3c - dia (git)

作図ソフト dia の改良版

Commit MetaInfo

• Revision: 0752d3219e9d36746939f5dc0e0d595119025a3c (tree)
• Zeit: 2014-09-05 20:55:36
• Autor: Hans Breuer <hans@breu...>
• Commiter: Hans Breuer

Log Message

[scan-build] Fix potential memory leak

Value stored to 'renderer' during its initialization is never read
File: /home/hb/from-git/dia/lib/diaimportrenderer.c
Line: 142

A user of DiaImportRenderer which would not call
dia_import_renderer_get_objects() after importing the data would
have leaked all the objects.

Ändern Zusammenfassung

• modified: lib/diaimportrenderer.c

Diff

--- a/lib/diaimportrenderer.c
+++ b/lib/diaimportrenderer.c
@@ -140,8 +140,14 @@ static void
 renderer_finalize (GObject *object)
 {
   DiaRenderer *renderer = DIA_RENDERER (object);
+  DiaImportRenderer *self = DIA_IMPORT_RENDERER (renderer);
 
-  /* XXX: anything to destroy */
+  /* anything more to destroy? */
+  if (self->objects) {
+    /* if no one called dia_import_renderer_get_objects() */
+    destroy_object_list(self->objects);
+    self->objects = NULL;
+  }
 
   G_OBJECT_CLASS (parent_class)->finalize (object);
 }
@@ -392,8 +398,8 @@ fill_arc (DiaRenderer *renderer, Point *center,
           real width, real height, real angle1, real angle2,
           Color *color)
 {
-  DiaImportRenderer *self = DIA_IMPORT_RENDERER (renderer);
 #if 0 /* does not work till 'Standard - Arc' supports filling */
+  DiaImportRenderer *self = DIA_IMPORT_RENDERER (renderer);
   DiaObject *object = _make_arc (center, width, height, angle1, angle2);
 
   _apply_style (self, object, color, NULL, 0.0);