Ticket #47681

sdl2: theme_default_font_size adjustments do not match adjustments of other fonts

Eröffnet am: 2023-03-25 11:56 Letztes Update: 2023-04-08 12:32

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
2

Details

When sdl2-client create_utf8_str() ends to using theme defined font size, it does not do adj_font() to it. Arguable, but I think we should treat the theme provided font size to be relative to other elements, so when we adjust everything else we should also adjust that one.

I don't think this is currently user-visible though; the adjustment is never used in practice (there's no way to enable small screen mode), and I suspect that theme provided font size is not used at all (-> going to open a new ticket about this)

Ticket-Verlauf (3/7 Historien)

2023-03-25 11:56 Aktualisiert von: cazfi
  • New Ticket "sdl2: theme_default_font_size adjusments do not match adjustments of other fonts" created
2023-03-27 10:15 Aktualisiert von: cazfi
  • Summary Updated
2023-03-27 10:18 Aktualisiert von: cazfi
2023-04-01 12:13 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
Kommentar

S3_0 patch meant also to S2_6 (while this is not a critical bug to fix in S2_6, later patches likely benefit from having this in the baseline)

Can be pushed to branches other than S3_0 already, S3_0 only after 3.0.7 release.

2023-04-08 12:32 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden