Ticket #42268

Threaded AI: segfault in master branch

Eröffnet am: 2021-05-15 06:31 Letztes Update: 2022-10-08 20:30

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
3

Details

Dev build built from master on Debian, using threaded AI

Build: commit 29f326871434d4a4a623b41b0deb5dd7dccbcb44 (HEAD -> master, origin/master, origin/HEAD) Author: Marko Lindqvist <cazfi74@gmail.com> Date: Wed Apr 28 02:38:55 2021 +0300

Server output --- there are a bunch of assertion failures one turn, but the crash was several turns later.

Game saved as freeciv-T0090-Y-0275-auto.sav.xz

Game saved as freeciv-T0091-Y-0250-auto.sav.xz

1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_act_get() [infracache.c::353]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ 1: in adv_city_worker_extra_get() [infracache.c::422]: assertion '((void *)0) != pcity->server.adv' failed. 1: Please report this message at https://osdn.net/projects/freeciv/ticket/ Game saved as freeciv-T0092-Y-0225-auto.sav.xz

Game saved as freeciv-T0093-Y-0200-auto.sav.xz

Game saved as freeciv-T0094-Y-0175-auto.sav.xz

Game saved as freeciv-T0095-Y-0150-auto.sav.xz

Game saved as freeciv-T0096-Y-0125-auto.sav.xz

Game saved as freeciv-T0097-Y-0100-auto.sav.xz

Segmentation fault

Don't have a coredump, can try to reproduce later.

I have all the savefiles and the config.status

Ticket-Verlauf (3/14 Historien)

2021-05-15 06:31 Aktualisiert von: andrewmcg
  • New Ticket "segfault in master branch" created
2021-05-15 16:36 Aktualisiert von: andrewmcg
Kommentar

I wasn't able to reproduce either the assertions or the crash by replaying from the savegame before

I would speculate the assertions were triggered from tai_tile_worker_task_select in taicity.c

2021-05-15 17:37 Aktualisiert von: cazfi
Kommentar

Threaded AI has known issues, I'm not sure if this is one. Anyway, it's likely we drop threaded AI completely, and concentrate on developing Tex AI where many of these problems are already fixed and which is generally more advanced.

2021-05-15 19:48 Aktualisiert von: andrewmcg
Kommentar

Reply To cazfi

Threaded AI has known issues, I'm not sure if this is one. Anyway, it's likely we drop threaded AI completely, and concentrate on developing Tex AI where many of these problems are already fixed and which is generally more advanced.

Oh OK, I couldn't work out how to run Tex AI -- is it --enable-aimodules=experimental ?

I'm mostly wanting to work on trying to improve the AI, that's why I was playing with threaded.

2021-05-22 14:07 Aktualisiert von: cazfi
  • Summary Updated
2022-10-02 00:40 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
  • Meilenstein Update from (Keine) to 3.2.0
  • Komponente Update from (Keine) to AI
Kommentar

Reply To cazfi

it's likely we drop threaded AI completely

That's what attached patch does.

2022-10-05 18:30 Aktualisiert von: cazfi
  • Lösung Update from Accepted to Keine
Kommentar

translations/core/POTFILES.in refers to threaded/threadedai.c

2022-10-05 21:02 Aktualisiert von: cazfi
  • Lösung Update from Keine to Accepted
Kommentar

Reply To cazfi

translations/core/POTFILES.in refers to threaded/threadedai.c

- Fixed

2022-10-05 23:48 Aktualisiert von: cazfi
  • Lösung Update from Accepted to Keine
Kommentar

"server/Makefile.am:139: error: AI_MOD_STATIC_THREADED does not appear in AM_CONDITIONAL"

2022-10-06 10:59 Aktualisiert von: cazfi
  • Lösung Update from Keine to Accepted
Kommentar

Reply To cazfi

"server/Makefile.am:139: error: AI_MOD_STATIC_THREADED does not appear in AM_CONDITIONAL"

Fixes

2022-10-08 20:30 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden