Ticket #45845

Adjust city name in network protocol

Eröffnet am: 2022-10-13 02:50 Letztes Update: 2024-10-19 00:13

Auswertung:
Verantwortlicher:
(Keine)
Typ:
Status:
Offen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Keine
Datei:
Keine

Details

Likely the network protocol could be made better concerning city names (in city_info etc), esp. after #45786 and #45844

Ticket-Verlauf (3/4 Historien)

2022-10-13 02:50 Aktualisiert von: cazfi
  • New Ticket "Adjust city name in network protocol" created
2022-10-27 01:54 Aktualisiert von: cazfi
Kommentar

Network protocol is already smart enough to send city name as NULL-terminated string, and not a fixed size array. So nothing to do for that.

Second thing considered was that city name could be moved to a packet of its own to avoid too big PACKET_CITY_INFO. For that part, there's a couple of much worse offenders -> will open a new tickets about those.
City name as part of PACKET_CITY_INFO isn't problem in S3_1. Let's recheck the situation before 3.2, especially if MAX_LEN_CITYNAME gets increased -> retargeting to S3_2-npf

2022-11-21 10:50 Aktualisiert von: cazfi
Kommentar

Reply To cazfi

Second thing considered was that city name could be moved to a packet of its own to avoid too big PACKET_CITY_INFO. For that part, there's a couple of much worse offenders -> will open a new tickets about those.

-> #46079, #46080

(Edited, 2022-11-21 11:08 Aktualisiert von: cazfi)
2024-10-19 00:13 Aktualisiert von: cazfi

Dateianhangliste

Keine Anhänge

Bearbeiten

Please login to add comment to this ticket » Anmelden