adv_best_government() has some government evaluation that should also be applied for the AI
I applied this patch mostly to check that it didn't do anything wrong. I didn't expect that it would change any behaviour noticeably. It might be that I'm checking more carefully now, or it might be that this patch is encouraging the AIs to choose The Republic more than they used to. Out of 20 AIs, 5 are currently running The Republic, while I feel that 'usually' it would be 1 or 2 (or 0) at this stage.
Reply To chippo
this patch is encouraging the AIs to choose The Republic more than they used to.
Does it seem like sensible thing for them to do in their current situation? The want values this exposes to AI code can be off by any amount, as they have probably been assumed to be actually used when they have been "tested" to not cause interference, which was a wrong assumption until this patch.
adv_best_government() call to dai_gov_value() sets override to TRUE meaning value evaluated by AI itself should be used. There has been a lot of code added to adv_best_government() that has no equivalent implementation in (or called from) dai_gov_value(), meaning that those evaluations are applicable only for advisor of a human player only (and we don't have such a advisor active, I think).