Andrew Morton
akpm****@linux*****
2015年 7月 10日 (金) 08:09:34 JST
On Wed, 1 Jul 2015 12:17:33 +0200 Laurent Dufour <ldufo****@linux*****> wrote: > The commit 2ae416b142b6 ("mm: new mm hook framework") introduced an empty > header file (mm-arch-hooks.h) for every architecture, even those which > doesn't need to define mm hooks. > > As suggested by Geert Uytterhoeven, this could be cleaned through the use > of a generic header file included via each per architecture > asm/include/Kbuild file. > > The PowerPC architecture is not impacted here since this architecture has > to defined the arch_remap MM hook. So the way this works is that if an arch wants to override a hook, it will remove the "generic-y += mm-arch-hooks.h" and add arch/XXX/include/asm/mm-arch-hooks.h, yes? And the new arch/XXX/include/asm/mm-arch-hooks.h only needs to define the hook(s) which the arch wants to override? So nothing will ever be added to include/asm-generic/mm-arch-hooks.h? Seems fair enough. Oleg is angling to remove arch_remap(), so there won't be anything left in these files! But there are plenty of ad-hoc things which *should* be moved over. > Changes in V2: > -------------- > - Vineet Gupta reported that the Kbuild files should be kept sorted. Yes, we do this to avoid patch collisions. Everyone always adds stuff to the end of the list (Makefiles, #includes, etc etc), thus carefully maximizing the number of patch collisions :(
Fork