Vineet Gupta
Vinee****@synop*****
2015年 7月 1日 (水) 21:51:06 JST
ForkOn Wednesday 01 July 2015 03:47 PM, Laurent Dufour wrote:
> The commit 2ae416b142b6 ("mm: new mm hook framework") introduced an empty
> header file (mm-arch-hooks.h) for every architecture, even those which
> doesn't need to define mm hooks.
>
> As suggested by Geert Uytterhoeven, this could be cleaned through the use
> of a generic header file included via each per architecture
> asm/include/Kbuild file.
>
> The PowerPC architecture is not impacted here since this architecture has
> to defined the arch_remap MM hook.
>
> Changes in V2:
> --------------
> - Vineet Gupta reported that the Kbuild files should be kept sorted.
> - Add fix for the newly introduced H8/300 architecture.
>
> Signed-off-by: Laurent Dufour <ldufo****@linux*****>
> Suggested-by: Geert Uytterhoeven <geert****@linux*****>
> CC: Andrew Morton <akpm****@linux*****>
> CC: Vineet Gupta <Vinee****@synop*****>
.
[snip]
> diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
> index 769b312c1abb..f2a3cdfee5f5 100644
> --- a/arch/arc/include/asm/Kbuild
> +++ b/arch/arc/include/asm/Kbuild
> @@ -23,6 +23,7 @@ generic-y += kvm_para.h
> generic-y += local.h
> generic-y += local64.h
> generic-y += mcs_spinlock.h
> +generic-y += mm-arch-hooks.h
> generic-y += mman.h
> generic-y += msgbuf.h
> generic-y += param.h
> diff --git a/arch/arc/include/asm/mm-arch-hooks.h b/arch/arc/include/asm/mm-arch-hooks.h
> deleted file mode 100644
> index c37541c5f8ba..000000000000
> --- a/arch/arc/include/asm/mm-arch-hooks.h
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -/*
> - * Architecture specific mm hooks
> - *
> - * Copyright (C) 2015, IBM Corporation
> - * Author: Laurent Dufour <ldufo****@linux*****>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - */
> -
> -#ifndef _ASM_ARC_MM_ARCH_HOOKS_H
> -#define _ASM_ARC_MM_ARCH_HOOKS_H
> -
> -#endif /* _ASM_ARC_MM_ARCH_HOOKS_H */
Acked-by: Vineet Gupta <vgupt****@synop*****> # for arch/arc
Thx,
-Vineet