sawad****@nttda*****
sawad****@nttda*****
2015年 8月 20日 (木) 13:19:31 JST
> -----Original Message----- > From: ludia****@lists***** > [mailto:ludia****@lists*****] On Behalf Of > ishii****@nttda***** > Sent: Thursday, August 20, 2015 11:13 AM > To: ludia****@lists***** > Subject: Re: [Ludiafuncs-hackers] Add regression tests > > Hi, > > I attached new patch. > I fixed the part of previous one. > > Changes from the last time: > ・Delete unnecessary "CREATE USER" > (We use "CREATE USER" only when we create normal user.) You can use SET ROLE and RESET ROLE command in order to do permission test, instead of adding textporter-close test. Two review comments. > expected/ludia_funcs.out:789: trailing whitespace. > +\c euc_db > expected/ludia_funcs.out:795: trailing whitespace. > +\c contrib_regression > sql/ludia_funcs.sql:176: trailing whitespace. > +\c euc_db > sql/ludia_funcs.sql:180: trailing whitespace. > +\c contrib_regression There are some unnecessary trailing whitespaces in 000_ludia_funcs_regress.patch as follows. > $ patch -d. -p1 < ../patch/ludia_funcs_regress_patch/001_ludia_funcs_regress_debug_option.patch > patching file Makefile > Hunk #1 FAILED at 33. > 1 out of 1 hunk FAILED -- saving rejects to file Makefile.rej I could not apply 001_ludia_funcs_regress_debug_option.patch successfully. It looks like both file debug_option.patch and textporter.patch have wrong prefix number each other. debug_options patch should be applied after textporter patch applied. Regards, -------- Masahiko Sawada
Fork