[Groonga-commit] ranguba/groonga-client at 40b7ff2 [master] Add convenient functions for adding parameter

Zurück zum Archiv-Index

Kouhei Sutou null+****@clear*****
Wed Mar 1 21:33:51 JST 2017


Kouhei Sutou	2017-03-01 21:33:51 +0900 (Wed, 01 Mar 2017)

  New Revision: 40b7ff2c0c895d84ae1d2558240800059a9f0d13
  https://github.com/ranguba/groonga-client/commit/40b7ff2c0c895d84ae1d2558240800059a9f0d13

  Message:
    Add convenient functions for adding parameter

  Modified files:
    lib/groonga/client/request/generic.rb
    lib/groonga/client/request/select.rb

  Modified: lib/groonga/client/request/generic.rb (+20 -0)
===================================================================
--- lib/groonga/client/request/generic.rb    2017-03-01 16:01:33 +0900 (7299e4b)
+++ lib/groonga/client/request/generic.rb    2017-03-01 21:33:51 +0900 (f66aa38)
@@ -37,6 +37,26 @@ module Groonga
                         RequestParameter.new(name, value))
         end
 
+        def flags_parameter(name_or_names, value)
+          if name_or_names.is_a?(Array)
+            names = name_or_names
+          else
+            names = [name_or_names]
+          end
+          add_parameter(OverwriteMerger,
+                        FlagsParameter.new(names, value))
+        end
+
+        def values_parameter(name_or_names, values)
+          if name_or_names.is_a?(Array)
+            names = name_or_names
+          else
+            names = [name_or_names]
+          end
+          add_parameter(OverwriteMerger,
+                        ValuesParameter.new(names, values))
+        end
+
         def to_parameters
           if****@param*****?
             {}

  Modified: lib/groonga/client/request/select.rb (+8 -13)
===================================================================
--- lib/groonga/client/request/select.rb    2017-03-01 16:01:33 +0900 (a17d6b5)
+++ lib/groonga/client/request/select.rb    2017-03-01 21:33:51 +0900 (f90180d)
@@ -38,9 +38,8 @@ module Groonga
           super(parameters, extensions)
         end
 
-        def match_columns(value)
-          add_parameter(OverwriteMerger,
-                        ValuesParameter.new([:match_columns], value))
+        def match_columns(values)
+          values_parameter([:match_columns], values)
         end
 
         def query(value)
@@ -160,9 +159,8 @@ module Groonga
             @label = label
           end
 
-          def keys(value)
-            add_parameter(OverwriteMerger,
-                          ValuesParameter.new([:"#{prefix}keys"], value))
+          def keys(values)
+            @request.values_parameter([:"#{prefix}keys"], values)
           end
 
           def sort_keys(value)
@@ -186,8 +184,7 @@ module Groonga
           end
 
           def calc_types(value)
-            add_parameter(OverwriteMerger,
-                          FlagsParameter.new([:"#{prefix}calc_types"], value))
+            @request.flags_parameter(:"#{prefix}calc_types", value)
           end
 
           def calc_target(value)
@@ -221,8 +218,7 @@ module Groonga
           end
 
           def flags(value)
-            add_parameter(OverwriteMerger,
-                          FlagsParameter.new([:"#{prefix}flags"], value))
+            @request.flags_parameter(:"#{prefix}flags", value)
           end
 
           def value(expression, values=nil)
@@ -265,9 +261,8 @@ module Groonga
           #   request object.
           #
           # @since 0.4.1
-          def group_keys(value)
-            add_parameter(OverwriteMerger,
-                          ValuesParameter.new([:"#{prefix}group_keys"], value))
+          def group_keys(values)
+            @request.values_parameter([:"#{prefix}group_keys"], values)
           end
 
           private
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Zurück zum Archiv-Index