Susumu Yata
null+****@clear*****
Thu Aug 24 14:20:59 JST 2017
Susumu Yata 2017-08-24 14:20:59 +0900 (Thu, 24 Aug 2017) New Revision: 06b0e81b42c404346733df347631ba946c6c8954 https://github.com/groonga/groonga/commit/06b0e81b42c404346733df347631ba946c6c8954 Message: Call is_negative_value at most once in number_safe_cast Modified files: lib/proc.c Modified: lib/proc.c (+5 -6) =================================================================== --- lib/proc.c 2017-08-24 12:03:41 +0900 (7927456f6) +++ lib/proc.c 2017-08-24 14:20:59 +0900 (ff6fe978e) @@ -1398,28 +1398,27 @@ number_safe_cast(grn_ctx *ctx, grn_obj *src, grn_obj *dest, grn_id type) GRN_UINT8_SET(ctx, dest, 0); return GRN_TRUE; } - /* fallthru */ + break; case GRN_DB_UINT16 : if (is_negative_value(src)) { GRN_UINT16_SET(ctx, dest, 0); return GRN_TRUE; } - /* fallthru */ + break; case GRN_DB_UINT32 : if (is_negative_value(src)) { GRN_UINT32_SET(ctx, dest, 0); return GRN_TRUE; } - /* fallthru */ + break; case GRN_DB_UINT64 : if (is_negative_value(src)) { GRN_UINT64_SET(ctx, dest, 0); return GRN_TRUE; } - /* fallthru */ - default : - return grn_obj_cast(ctx, src, dest, GRN_FALSE) == GRN_SUCCESS; + break; } + return grn_obj_cast(ctx, src, dest, GRN_FALSE) == GRN_SUCCESS; } static inline int -------------- next part -------------- HTML����������������������������...Download
