[Groonga-commit] droonga/droonga-engine at da402d6 [master] Use named parameters instead of confusable list of arguments

Zurück zum Archiv-Index

YUKI Hiroshi null+****@clear*****
Thu Apr 30 11:40:23 JST 2015


YUKI Hiroshi	2015-04-30 11:40:23 +0900 (Thu, 30 Apr 2015)

  New Revision: da402d6e1f7310b5158f0bd2cc67eae49fff80d9
  https://github.com/droonga/droonga-engine/commit/da402d6e1f7310b5158f0bd2cc67eae49fff80d9

  Message:
    Use named parameters instead of confusable list of arguments

  Modified files:
    lib/droonga/engine.rb
    lib/droonga/engine_state.rb

  Modified: lib/droonga/engine.rb (+6 -5)
===================================================================
--- lib/droonga/engine.rb    2015-04-30 11:38:24 +0900 (d4b0970)
+++ lib/droonga/engine.rb    2015-04-30 11:40:23 +0900 (de15685)
@@ -41,13 +41,14 @@ module Droonga
       @internal_name = internal_name
       @loop = loop
       @catalog = load_catalog
-      @state = EngineState.new(loop, name,
-                               internal_name,
-                               :catalog  => @catalog,
+      @state = EngineState.new(:loop          => loop,
+                               :name          => name,
+                               :internal_name => internal_name,
+                               :catalog       => @catalog,
                                :internal_connection_lifetime =>
                                  options[:internal_connection_lifetime])
-      @cluster = Cluster.new(:loop     => loop,
-                             :catalog  => @catalog,
+      @cluster = Cluster.new(:loop    => loop,
+                             :catalog => @catalog,
                              :internal_connection_lifetime =>
                                options[:internal_connection_lifetime])
 

  Modified: lib/droonga/engine_state.rb (+4 -4)
===================================================================
--- lib/droonga/engine_state.rb    2015-04-30 11:38:24 +0900 (4afa93e)
+++ lib/droonga/engine_state.rb    2015-04-30 11:40:23 +0900 (8db3d2e)
@@ -37,10 +37,10 @@ module Droonga
     attr_accessor :catalog
     attr_accessor :on_finish
 
-    def initialize(loop, name, internal_name, params)
-      @loop = loop
-      @name = name
-      @internal_name = internal_name
+    def initialize(params)
+      @loop = params[:loop]
+      @name = params[:name]
+      @internal_name = params[:internal_name]
       @internal_connection_lifetime = params[:internal_connection_lifetime]
       @sessions = {}
       @current_id = 0
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Zurück zum Archiv-Index