[Groonga-commit] groonga/groonga-admin at 79fff4c [master] Extract common code

Zurück zum Archiv-Index

Kouhei Sutou null+****@clear*****
Tue Nov 4 14:55:55 JST 2014


Kouhei Sutou	2014-11-04 14:55:55 +0900 (Tue, 04 Nov 2014)

  New Revision: 79fff4c34a4181562e670994d098058925d67503
  https://github.com/groonga/groonga-admin/commit/79fff4c34a4181562e670994d098058925d67503

  Message:
    Extract common code

  Modified files:
    app/scripts/controllers/table-search-controller.js

  Modified: app/scripts/controllers/table-search-controller.js (+13 -16)
===================================================================
--- app/scripts/controllers/table-search-controller.js    2014-11-04 14:53:04 +0900 (607973c)
+++ app/scripts/controllers/table-search-controller.js    2014-11-04 14:55:55 +0900 (f9e2661)
@@ -29,23 +29,20 @@ angular.module('groongaAdminApp')
       $scope.clear  = clear;
     }
 
-    function search() {
-      var matchColumns = $scope.indexedColumns
-          .filter(function(indexedColumn) {
-            return indexedColumn.inUse;
-          })
-          .map(function(indexedColumn) {
-            return indexedColumn.name;
-          })
-          .join(',');
-      var outputColumns = $scope.outputColumns
-          .filter(function(outputColumn) {
-            return outputColumn.inUse;
-          })
-          .map(function(outputColumn) {
-            return outputColumn.name;
+    function packUsedColumns(columns) {
+      var targetColumnNames = columns
+          .filter(function(column) {
+            return column.inUse;
           })
-          .join(',');
+          .map(function(column) {
+            return column.name;
+          });
+      return targetColumnNames.join(',');
+    }
+
+    function search() {
+      var matchColumns = packInUseColumns($scope.indexedColumns);
+      var outputColumns = packInUseColumns($scope.outputColumns);
       var parameters = angular.extend({},
                                       $scope.parameters,
                                       {
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Zurück zum Archiv-Index