[Groonga-commit] groonga/grntest [master] Remove needless ? from method name because of returing non boolean value

Zurück zum Archiv-Index

HAYASHI Kentaro null+****@clear*****
Mon Nov 19 15:26:12 JST 2012


HAYASHI Kentaro	2012-11-19 15:26:12 +0900 (Mon, 19 Nov 2012)

  New Revision: 8cfc9036384e059bd263a4776a6f792df9250514
  https://github.com/groonga/grntest/commit/8cfc9036384e059bd263a4776a6f792df9250514

  Log:
    Remove needless ? from method name because of returing non boolean value

  Modified files:
    lib/grntest/tester.rb
    test/test-executor.rb

  Modified: lib/grntest/tester.rb (+1 -1)
===================================================================
--- lib/grntest/tester.rb    2012-11-19 15:14:00 +0900 (8ca3a86)
+++ lib/grntest/tester.rb    2012-11-19 15:26:12 +0900 (1a07145)
@@ -1182,7 +1182,7 @@ EOF
           @db_path.relative_path_from(@temporary_directory_path)
         end
 
-        def on_error?
+        def on_error
           @on_error
         end
       end

  Modified: test/test-executor.rb (+2 -2)
===================================================================
--- test/test-executor.rb    2012-11-19 15:14:00 +0900 (444ae32)
+++ test/test-executor.rb    2012-11-19 15:26:12 +0900 (f1fbd8a)
@@ -53,9 +53,9 @@ class TestExecutor < Test::Unit::TestCase
     end
 
     def test_enable_ignore_feature_on_error
-      assert_not_equal(@context.on_error?, :omit)
+      assert_not_equal(@context.on_error, :omit)
       execute("\#@on-error omit")
-      assert_equal(@context.on_error?, :omit)
+      assert_equal(@context.on_error, :omit)
     end
   end
 
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Zurück zum Archiv-Index