ap_diplomat_battle() nonnull target_tile

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.0.8 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 3

Details

Seen on S3_0; clang analyzer gives warnings about NULL dereference with tgt_tile parameter of ap_diplomat_battle().

Should probably make it nonnull, and see what further issues that reveals.

Ticket-Verlauf (3/6 Historien)

2023-05-24 20:32 Aktualisiert von: cazfi

• New Ticket "ap_diplomat_battle() nonnull target_tile" created

2023-05-27 05:19 Aktualisiert von: cazfi

• File 0016-Add-nonnull-attribute-to-ap_diplomat_battle-tgt_tile.patch (File ID: 12484) is attached

2023-05-27 05:20 Aktualisiert von: cazfi

• File 0009-Add-nonnull-attribute-to-ap_diplomat_battle-tgt_tile.patch (File ID: 12485) is attached

2023-05-27 05:20 Aktualisiert von: cazfi

• File 0005-Fix-ap_diplomat_battle-clang-analyzer-warnings.patch (File ID: 12486) is attached

2023-05-27 05:21 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar

Reply To cazfi

Should probably make it nonnull, and see what further issues that reveals.

S3_1 - main were not affected, but the "nonnull attribute" part done in attached patches anyway. S3_0 patch has more comprehensive fix.

2023-05-29 13:05 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt