Putting on hold for now, as Ihnatus suggests basing NoVeteran functionality *more* on effects (and dropping "Gain Veterancy" action enabler): https://forum.freeciv.org/f/viewtopic.php?t=93908
Reply To cazfi
Putting on hold for now, as Ihnatus suggests basing NoVeteran functionality *more* on effects (and dropping "Gain Veterancy" action enabler): https://forum.freeciv.org/f/viewtopic.php?t=93908
While that suggestion is not against the core idea of this ticket, current implementation is likely counter-productive in relation to that suggestion (removing "NoVeteran" requirements from many effects in supplied rulesets)
Reply To cazfi
Reply To cazfi
Putting on hold for now, as Ihnatus suggests basing NoVeteran functionality *more* on effects (and dropping "Gain Veterancy" action enabler): https://forum.freeciv.org/f/viewtopic.php?t=93908
While that suggestion is not against the core idea of this ticket, current implementation is likely counter-productive in relation to that suggestion (removing "NoVeteran" requirements from many effects in supplied rulesets)
As we already have "Gain Veterancy" as an internal action, testing without this patch produces warnings about extraneous flags. I think this should now go in, to reach some stable point. We can revert everything at once, if we later so decide.
Patch rebased, on top of #48027
After #48000 removes last hardcoded use of "NoVeteran" flag, entire flag can be dropped. Rulesets that need it, should implement it as a user unit type flag.