Ticket #47887

Counters description - client side.

Eröffnet am: 2023-04-20 21:37 Letztes Update: 2024-05-25 01:29

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
3
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
5

Details

Related to: #47697

#47697 is server-part and this is for client. Counters should deliver description about what it mean for gameplay and current value/checkpoint. For city counters, made this information visible in city dialog.

Ticket-Verlauf (3/23 Historien)

2023-04-20 21:37 Aktualisiert von: lachu
  • New Ticket "Counters description - client side." created
2023-04-22 02:27 Aktualisiert von: lachu
Kommentar
0001-OSDN-47887-S-awomir-Lach-slawek-lach.art.pl.patch(6KB)
Gtk3.22 client changes - repair segfault

is successor of: 0001-OSDN-47887-S-awomir-Lach-slawek-lach.art.pl.patch(6KB)

Gtk3.22 client changes
2023-04-23 21:35 Aktualisiert von: lachu
Kommentar

This patch probably cause segfault, when dialogs of two windows were open. I must investigate, why. On main everything works.

2023-04-23 22:22 Aktualisiert von: lachu
Kommentar

I see client do not crash always. Now it work properly. I must investigate.

2023-05-04 17:09 Aktualisiert von: lachu
Kommentar
0001-OSDN-47887-S-awomir-Lach-slawek-lach.art.pl.patch(6KB)
Fix crash

@cazfi: Crash was made by not initialized variables.

2023-05-09 11:53 Aktualisiert von: cazfi
Kommentar

gtk has its own macros to cast compatible types. Use that instead of really arbitrary casts. "(GtkContainer*) page" -> "GTK_CONTAINER(page)" etc.

2023-05-13 01:42 Aktualisiert von: lachu
Kommentar

Reply To cazfi

gtk has its own macros to cast compatible types. Use that instead of really arbitrary casts. "(GtkContainer*) page" -> "GTK_CONTAINER(page)" etc.

2023-05-13 01:42 Updated by: lachu

File 0001-OSDN-47887-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 12396) is attached
2024-03-26 00:12 Aktualisiert von: lachu
Kommentar

What's about this ticket?

2024-04-19 21:51 Aktualisiert von: cazfi
Kommentar

- Use fc_snprintf() instead of snprintf()
- I'd prefer Counters tab to be between Happiness and Governor, not already before Production

2024-04-21 20:05 Aktualisiert von: lachu
  • File 0001-OSDN-47887-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 13730) is attached
2024-04-21 20:06 Aktualisiert von: lachu
  • File 0001-OSDN-47887-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 13730) is deleted
2024-04-21 20:07 Aktualisiert von: lachu
Kommentar

Reply To cazfi

- Use fc_snprintf() instead of snprintf()
- I'd prefer Counters tab to be between Happiness and Governor, not already before Production

0001-OSDN-47887-S-awomir-Lach-slawek-lach.art.pl.patch(6KB)
Small changes - implementation

Done.

2024-05-04 23:27 Aktualisiert von: cazfi
  • Lösung Update from Keine to Accepted
  • Meilenstein Update from (Keine) to 3.2.0
2024-05-04 23:31 Aktualisiert von: cazfi
Kommentar

Same for...

gtk4-client -> #58897
Qt-client -> #58898

Didn't create sdl2-client ticket yet, but that too can of course be made.

2024-05-07 20:43 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt
Kommentar

Same for...

gtk4-client -> #58897
Qt-client -> #58898

Didn't create sdl2-client ticket yet, but that too can of course be made.

2024-05-20 23:36 Aktualisiert von: None
Kommentar

Reply To cazfi

Same for... gtk4-client -> #58897
Qt-client -> #58898
Didn't create sdl2-client ticket yet, but that too can of course be made.

Those tickets was removed?

2024-05-24 00:56 Aktualisiert von: lachu
Kommentar

GTK4: https://osdn.net/projects/freeciv/ticket/117691

Reply To cazfi

Same for... gtk4-client -> #58897
Qt-client -> #58898
Didn't create sdl2-client ticket yet, but that too can of course be made.

2024-05-25 01:29 Aktualisiert von: lachu
Kommentar

Reply To cazfi

Same for... gtk4-client -> #58897
Qt-client -> #58898
Didn't create sdl2-client ticket yet, but that too can of course be made.

https://osdn.net/projects/freeciv/ticket/117692#preview Qt5 client (first step to implement support in Qt5).

Dateianhangliste

Bearbeiten

Please login to add comment to this ticket » Anmelden