homebrew-appbundle.sh: Set correct version number

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Patches
• Status: Geschlossen
• Komponente: Bootstrap
• Meilenstein: 3.1.0-beta1 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details Antworten

Noticed that homebrew-appbundle.sh sets hardcoded "3.1.0-alpha" version string to info file, regardless of the freeciv version.

Ticket-Verlauf (3/6 Historien)

2023-02-18 10:55 Aktualisiert von: cazfi

• New Ticket "homebrew-appbundle.sh: Set correct version number" created

2023-02-19 02:23 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to ddeanbrown

Kommentar Antworten

- Should be relatively easy to implement - just run fc_version from the source root to get the version
- Failing actual code update before 3.1.0-beta1, we need to adjust our release process (for that release) so that the hardcoded version numbers are set correctly

2023-02-28 12:23 Aktualisiert von: ddeanbrown

• File homebrew-appbundle.sh.patch (File ID: 11737) is attached

2023-02-28 12:23 Aktualisiert von: ddeanbrown

Kommentar Antworten

This patch should do it.

2023-02-28 19:49 Aktualisiert von: cazfi

• Verantwortlicher Update from ddeanbrown to cazfi
• Lösung Update from Keine to Accepted

Kommentar Antworten

Thanks. But please try not to include unrelated changes to a patch in the future (here especially the gtk3.22-client -> gtk4-client switch - I'm inclined to just add mention of that to the commit message this time when I push this in, instead of rejecting the entire patch because of it)

2023-03-03 06:17 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt