tileset_setup_unit_direction() expects unit_activity_name(ACTIVITY_LAST) to be valid string

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Client common
• Meilenstein: 3.2.0
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

Even when called with ACTIVITY_LAST, tileset_setup_unit_direction() does:

--

fc_snprintf(buf, sizeof(buf), "%s_%s_%s", base_str,

unit_activity_name(activity),
dir_get_tileset_name(loaddir));

Ticket-Verlauf (3/5 Historien)

2023-01-07 00:10 Aktualisiert von: cazfi

• New Ticket "tileset_setup_unit_direction() expects unit_activity_name(ACTIVITY_LAST) to be valid string" created

2023-01-07 00:16 Aktualisiert von: cazfi

Kommentar

Though it's not possible to end there with such illegal activity, heuristics of a bit older gcc (seen on Ubuntu Focal) fail to find that out, and give a warning.

2023-01-07 01:11 Aktualisiert von: cazfi

• File 0040-tileset_setup_unit_direction-Fix-gcc-9-warning.patch (File ID: 11323) is attached

2023-01-07 01:11 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

2023-01-12 03:31 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt