blank ruleset widget when starting new game - meson built
ddeanbrown Which client? What exact point of S3_1 (preferably the commit hash)? e.g. the recent FREECIV_DATA_PATH changes could affect if rulesets are found to populate the widget.
Note that on master that's broken because of master-specific changes to how the list of rulesets end to the client.
ddeanbrown Both qt and gtk3.22 clients.
Just did a fresh build with a refreshed pull of S3_1 and the gtk3.22 client works OK, so the recent FREECIV_DATA_PATH changes must have fixed it. Which commits were they? I can't find them.
qt client fails to start server - incompatible capability strings. That's a separate unrelated issue.
Reply To ddeanbrown
Both qt and gtk3.22 clients. Just did a fresh build with a refreshed pull of S3_1 and the gtk3.22 client works OK, so the recent FREECIV_DATA_PATH changes must have fixed it. Which commits were they?
984f8d9e6aaeab27ae6efc783dfe10437b825b93
qt client fails to start server - incompatible capability strings. That's a separate unrelated issue.
Sounds like you are either having issues with incremental builds not rebuilding everything they should, or the client finding wrong server.
ddeanbrown Something must have been dodgy in my previous build, so did a fresh build from scratch of S3_1 pull as of today. This fixed the red herring with the incompatible capability strings. And made the original reported bug come back. Guess that commit was also a red herring. Digging some more, what I now see is that setting that widget to "default" fails because "default" is not in the list of rulesets, because "default.serv" is not in the installed ".../share/freeciv" folder, because meson.build doesn't include it in the install_data section that installs the other 'data/*.serv' files. Patch attached.
ddeanbrown Reply To ddeanbrown
Digging some more
Great work! While the master regression affecting also autotools is a bit different, your finding about missing "default" info causing the client side behavior likely explain it too.
Prefered patch format is what you get by writing local commits to a file with 'git format-patch'. That way you get the metadata (like author) included.
I think this should go to S3_1 only - doesn't really make sense to install deprecated .serv on master.
ddeanbrown ddeanbrown ddeanbrown Better patch file.
Seen in S3_1 branch built with meson, OK with autotools build.
Choose "Start new game", the next dlog has widget "Ruleset: " with blank value. ("Rules: " widget with qt client.)
Seen on my Mac, possibly Mac only bug?