city_rally_point_receive() 'pcity' should not be nonnull

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.1.0-beta1 (closed)
• Priorität: 9 - Höchste
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

CI build mac-meson complains about the fact that city_rally_point_receive() makes a tautological check against NULL pcity while the parameter is defined nonnull.

I think we have to support NULL pcity there, even though I've not seen any compiler to give an error about NULL passed now that it has been nonnull.

Ticket-Verlauf (3/4 Historien)

2022-12-16 01:02 Aktualisiert von: cazfi

• New Ticket "city_rally_point_receive() 'pcity' should not be nonnull" created

2022-12-16 01:08 Aktualisiert von: cazfi

• File 0021-city_rally_point_receive-Remove-nonnull-attribute-fr.patch (File ID: 11111) is attached

2022-12-16 01:09 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted
• Priorität Update from 5 - Mittel to 9 - Höchste

Kommentar

As a (macos) build breakage, should be treated as an emergency fix. Will test the attached patch and then push immediately, if seems fine.

2022-12-16 02:44 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt