What is currently sg_load_sanitycheck() in both savegame2.c and savegame3.c does not depend on the savegame format (2 or 3). The game state should be similarly sane after the savegame has been loaded in either case. Move that functionality to a new "savesanity.[ch]" -module?
Reply To cazfi
The game state should be similarly sane after the savegame has been loaded in either case.
Comparison of the function in savegame2.c and savegame3.c reveal some differences in what they fix. So it's by the very idea of having separate sg2 and sg3 that latter does not need to do things for very old saves that sg2 needs to -> abandoning the idea of this ticket.