Ticket #45910

oblig_hard_req_reg() for zero action results

Eröffnet am: 2022-10-18 03:07 Letztes Update: 2022-12-04 13:24

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

Originally detected by valgrind as a memory leak: One of the oblig_hard_req_reg() calls has no target action results (list is immediately terminated by ACTRES_NONE). With zero users to begin with, nobody reduces its reference count and thus code to free it is never triggered.

It's likely that a more serious bug than tiny memory leak lurks there - certainly it was not created to be registered to no action.

It's the one about war with tile owner OR tile having no city.

Ticket-Verlauf (3/6 Historien)

2022-10-18 03:07 Aktualisiert von: cazfi
  • New Ticket "oblig_hard_req_re() for zero action results" created
2022-10-18 07:23 Aktualisiert von: cazfi
  • Summary Updated
2022-10-30 15:02 Aktualisiert von: cazfi
  • Meilenstein Update from (Keine) to 3.2.0
  • Komponente Update from (Keine) to General
Kommentar

Reply To cazfi

It's likely that a more serious bug than tiny memory leak lurks there - certainly it was not created to be registered to no action.

It's used in S3_1, for ACTRES_BOMBARD. It's no longer an obligatory bombard requirement in master. The oblig_hard_req_reg() call just wasn't removed when the only action previously registered to it stopped being registered to it.

2022-11-28 05:53 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
2022-12-04 13:24 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden