Ticket #45687

gtk: Dead 'bg' assignment in create_tech_tree()

Eröffnet am: 2022-09-23 12:22 Letztes Update: 2023-01-03 05:13

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
3

Details

Clang analyzer warns that create_tech_tree() assignment of 'bg = COLOR_REQTREE_BACKGROUND;' is never used. That's true as following switch sets 'bg' for each possible value of the enum.

It doesn't seem like a terrible idea to have that assignment in place, in case there's ever an illegal enum value (one that the switch won't catch), but maybe we change this regardless, to avoid clang analyzer spam about it?

Ticket-Verlauf (3/7 Historien)

2022-09-23 12:22 Aktualisiert von: cazfi
  • New Ticket "gtk: Dead 'bg' assignment in create_tech_tree()" created
2022-10-11 22:28 Aktualisiert von: cazfi
Kommentar

I think #45831 should be resolved first.

2022-12-28 06:55 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
  • Meilenstein Update from (Keine) to 3.0.6 (closed)
2023-01-03 05:13 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden