can_player_build_unit_direct() double is_barbarian() call

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.2.0
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

can_player_build_unit_direct() does 'barbarian = is_barbarian(p)" assignment twice (in the beginning, and a bit later. It's already needed before the latter one). As it's a function call, compiler even cannot leave one out.

Ticket-Verlauf (3/4 Historien)

2022-09-10 09:41 Aktualisiert von: cazfi

• New Ticket "can_player_build_unit_direct() double is_barbarian() call" created

2022-10-06 07:18 Aktualisiert von: cazfi

• File 0032-Drop-extraneous-is_barbarian-call-from-can_player_bu.patch (File ID: 10477) is attached

2022-10-06 07:18 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

2022-10-10 12:23 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt