"section_list_destroy(sec);" with garbage 'sec'

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Server
• Meilenstein: 3.0.4 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

From clang analyzer report from S3_0.

load_ruleset_nations() does not set 'sec' if there's issues detected in earlier part of the function (it gets set only within later "if (ok) {" -block). Regardless, in the cleanup phase there's an assumption that if it's not NULL, it's leftover from abort within the block that uses it.

/* Clean up on aborted load */
if (sec) {

fc_assert(!ok);
section_list_destroy(sec);

}

Ticket-Verlauf (3/4 Historien)

2022-09-01 00:32 Aktualisiert von: cazfi

• New Ticket ""section_list_destroy(sec);" with garbage 'sec'" created

2022-09-25 20:22 Aktualisiert von: cazfi

• File 0045-load_ruleset_nations-Fix-section_list_destroy-call-w.patch (File ID: 10395) is attached

2022-09-25 20:23 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar

Going to push also to S2_6

2022-10-02 13:25 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt