inf magic error after a parse error in included file

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.0.4 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

When there's a parse error in an included file, resulting in a inf_close() call to that file:

1. inf_close() gets called recursively for the including file, as per inf->included_from
2. inf_close_partial() for the included file itself does inf_sanity_check()
3. In case of FREECIV_DEBUG build, inf_sanity_check() calls itself recursively for the including file (inf->included_from)
4. As that including file was already closed in (1), the sanity check makes all kind of illegal memory accesses

Ticket-Verlauf (3/6 Historien)

2022-08-22 02:29 Aktualisiert von: cazfi

• New Ticket "ing magic error after a parse error in included file" created

2022-08-22 03:54 Aktualisiert von: cazfi

• Summary Updated

2022-08-28 15:41 Aktualisiert von: cazfi

• Meilenstein Update from (Keine) to 3.0.4 (closed)

2022-09-03 11:26 Aktualisiert von: cazfi

• File 0048-Stop-inf-file-recursing-to-already-closed-including-.patch (File ID: 10228) is attached

2022-09-03 11:26 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar

Going to push even to S2_6

2022-09-10 11:40 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt