Ticket #45240

Garbage defender in send_combat()

Eröffnet am: 2022-07-26 19:27 Letztes Update: 2022-08-10 15:26

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

I'm looking at map_get_seen() segfault with the new fantasy ruleset. So far it seems that pdefender in send_combat() is garbage pointer (or at least it points to garbage content), which then leads to garbage playermap pointer to access seen counters.

Ticket-Verlauf (3/6 Historien)

2022-07-26 19:27 Aktualisiert von: cazfi
  • New Ticket "Garbage defender in send_combat()" created
2022-07-26 19:52 Aktualisiert von: cazfi
Kommentar

It seems that unit_attack_civilian_casualties() call causes the city to get destroyed, taking supported units with it, and the failed defender was one of those.

2022-07-26 19:55 Aktualisiert von: cazfi
  • Meilenstein Update from (Keine) to 3.2.0
  • Komponente Update from (Keine) to Server
Kommentar

Only master affected, as older branches do not reduce city size in case it's already 1, i.e., city never gets destroyed in that call.

2022-08-01 12:36 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
2022-08-10 15:26 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden