Prefer signal.h over sys/signal.h

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Patches
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.0.6 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 2

Details

netintf.c includes sys/signal.h instead of signal.h, though that is far from recommendations. I believe that reason is ancient - some *nix where freeciv was developed in the 90's had some issue with signal.h (not yet standardised to that over sys/signal.h). Likely there's no reason to keep it that way 202x.

Ticket-Verlauf (3/7 Historien)

2022-07-04 02:46 Aktualisiert von: cazfi

• New Ticket "Prefer signal.h over sys/signal.h" created

2022-07-04 02:50 Aktualisiert von: cazfi

• File 0061-Prefer-signal.h-over-sys-signal.h.patch (File ID: 9700) is attached

2022-07-04 02:50 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

2022-07-15 00:47 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt

2023-01-17 10:23 Aktualisiert von: cazfi

• File 0006-Prefer-signal.h-over-sys-signal.h.patch (File ID: 11383) is attached

2023-01-17 10:24 Aktualisiert von: cazfi

• Status Update from Geschlossen to Offen
• Lösung Update from Gefixt to Accepted
• Meilenstein Update from 3.1.0 (closed) to 3.0.6 (closed)

Kommentar

This issue affects void linux / musl build also in older branches - let's backport the fix. Old patch applies to S3_0. For S2_6 a new patch has been attached.

2023-01-19 04:08 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt