generate_packets.py: remove no-packet flag

• Auswertung: alienvalkyrie
• Verantwortlicher: alienvalkyrie
• Typ: Patches
• Status: Geschlossen
• Komponente: Bootstrap
• Meilenstein: 3.2.0
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 2

Details

Part of #43927. The packet flag no-packet produces send methods that do not take a packet struct as argument. Such code is only valid for packets with no fields (e.g. PACKET_SERVER_SHUTDOWN), in which case the flag is automatically added anyway. It has also never been explicitly added to a packet since the delta protocol was first committed.

~> remove it as a settable flag (while keeping the "empty packet send methods take no packet struct" behavior).

Ticket-Verlauf (3/7 Historien)

2022-07-02 06:03 Aktualisiert von: alienvalkyrie

• New Ticket "generate_packets.py: remove no-packet flag" created

2022-07-02 06:29 Aktualisiert von: alienvalkyrie

• File 0002-generate_packets.py-Remove-no-packet-flag.patch (File ID: 9661) is attached

2022-07-02 06:29 Aktualisiert von: alienvalkyrie

• Lösung Update from Keine to Accepted

2022-07-02 07:19 Aktualisiert von: alienvalkyrie

• Lösung Update from Accepted to Keine

Kommentar

Still need to remove mentions in packets.def comments

2022-07-02 07:22 Aktualisiert von: alienvalkyrie

• File 0002-generate_packets.py-Remove-no-packet-flag.patch (File ID: 9662) is attached

2022-07-02 07:23 Aktualisiert von: alienvalkyrie

• Lösung Update from Keine to Accepted

2022-07-03 21:34 Aktualisiert von: alienvalkyrie

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt