Ticket #44959

Savegame:Use saved diplstate order

Eröffnet am: 2022-06-27 09:55 Letztes Update: 2022-09-20 11:16

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

Diplstate order is being saved to the savegame, but it's not used in the loading side.

Presumably the reason for that the saving side has been implemented in earlier versions already is for the benefit of newer versions loading such savegames - no need to keep the order present in "historical" versions listed in the newer version binary.

We should implement the loading side too. Targeting initially to master only, but should also confirm that S3_1 still has the same hardcoded order as the earlier versions (so it's ok to keep using that hardcoded order)

Ticket-Verlauf (3/7 Historien)

2022-06-27 09:55 Aktualisiert von: cazfi
  • New Ticket "Savegame:Use saved diplstate order" created
2022-08-31 07:44 Aktualisiert von: cazfi
Kommentar

Resolving "unused entry" warnings about diplstates in stable branches -> #45527

2022-08-31 08:19 Aktualisiert von: cazfi
Kommentar

Diplstate order actually IS loaded in savegame2.c case. For some reason that has not made it to savegame3.c

2022-09-08 01:00 Aktualisiert von: cazfi
Kommentar

Reply To cazfi

Diplstate order actually IS loaded in savegame2.c case. For some reason that has not made it to savegame3.c

The thing seems to be that savegame3.c does not save values as integers, but by name. So there's no need to have the order (mapping from integers to names) in the savegame.

So, this ticket turns to one to stop saving the useless information on savegame3.c.

2022-09-11 13:51 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
2022-09-20 11:16 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Bearbeiten

Please login to add comment to this ticket » Anmelden