Redundant check in citizens_update()

• Auswertung: ihnatus
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Server
• Meilenstein: 3.0.5 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details Antworten

int selected = fc_rand(count); ... if (selected != count) is always true. That does not change the result (just sometimes we assign a thing to itself) but is redundant.

Ticket-Verlauf (3/6 Historien)

2022-06-18 05:28 Aktualisiert von: ihnatus

• New Ticket "Redundant check in citizens_update()" created

2022-08-05 08:59 Aktualisiert von: cazfi

• Meilenstein Update from 3.0.3 (closed) to 3.0.4 (closed)
• Schweregrad Update from 4 to 5 - Mittel

2022-10-07 09:30 Aktualisiert von: cazfi

• Meilenstein Update from 3.0.4 (closed) to 3.0.5 (closed)

2022-10-08 10:58 Aktualisiert von: cazfi

• File 0041-citizens_update-Remove-redundant-and-broken-check.patch (File ID: 10522) is attached

2022-10-08 11:02 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar Antworten

Considered adjusting the check to at least to work correctly (use 'count - 1') but went for complete removal in the end. That also allowed integrating previously separate 'count--'.

A bit undecided, but proposing this patch now anyway.

2022-10-15 12:09 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt