Ticket #44825

Elefant Cimpletoon Renderers

Eröffnet am: 2022-06-14 10:43 Letztes Update: 2022-06-21 23:57

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
2

Details

Some cimpletoon render rigs for freeciv.

Ticket-Verlauf (3/12 Historien)

2022-06-14 10:43 Aktualisiert von: elefant
  • New Ticket "Elefant Cimpletoon Renderers" created
2022-06-17 11:42 Aktualisiert von: elefant
  • File 0001-add-cimpletoon-renderers-to-data-graphics-folder.patch (File ID: 9521) is attached
2022-06-17 11:49 Aktualisiert von: elefant
  • File 0001-add-cimpletoon-renderers-to-data-graphics-folder.patch (File ID: 9521) is deleted
2022-06-17 17:28 Aktualisiert von: cazfi
  • Komponente Update from (Keine) to Art
Kommentar

As for your concern if the patch file is correctly formed: It applies, and it adds those .blends under new data/graphics/Elefant-Cimpletoon-Renderers/ directory. So seems fine for that part.

Your git.email seems to be "Elefant@Elefant-PC.lan" as the Author-field of the commit is: "Author: Elefant <Elefant@Elefant-PC.lan>"
Do you want to keep it that way, or to rework it some way? We do have commits that point emails like "..-no-reply@..." etc, but I don't remember invalid domain part ever being used before.

2022-06-20 04:43 Aktualisiert von: cazfi
Kommentar

If you want, I can reset the author field of this patch for you. Just tell what email you want used.

Just so that we would get this first one handled.

2022-06-20 10:10 Aktualisiert von: elefant
Kommentar

Changed email address

2022-06-20 10:12 Aktualisiert von: elefant
Kommentar

Preferably, if someone wants to contact me, they should reply to a ticket of mine or message me on the forums.

2022-06-20 11:21 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
  • Meilenstein Update from (Keine) to 3.1.0 (closed)
Kommentar

I wasn't quite sure what versions to target, but maybe these get used for some 3.1 work?

Setting status to "Accepted" means that the review period (there's no better status for that in OSDN) started. People have at least 36h to comment.

2022-06-20 11:47 Aktualisiert von: elefant
Kommentar

Any version should be fine.

2022-06-21 23:57 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt
Kommentar

Commits pushed. You should get credit of your first freeciv contribution in OpenHUB when they rerefresh their stats next time: https://www.openhub.net/p/freeciv/contributors/summary

Bearbeiten

Please login to add comment to this ticket » Anmelden