kill_unit() constantly calling player_slot_count()

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Server
• Meilenstein: 3.0.3 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

kill_unit() calls player_slot_count() many times. The value returned will be the same every time, so should just call it once, and store the value in a variable. This should also help with some clang analyzer warnings that alerted me to this issue - compiler cannot know that each of those calls return the same value.

Ticket-Verlauf (3/4 Historien)

2022-06-11 21:47 Aktualisiert von: cazfi

• New Ticket "kill_unit() constantly calling player_slot_count()" created

2022-06-21 22:53 Aktualisiert von: cazfi

• File 0056-kill_unit-Call-player_slot_count-just-once.patch (File ID: 9574) is attached

2022-06-21 22:53 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

2022-06-29 06:25 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt