sdl2: city_map_canvas not freed on client exit

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: SDL2-client
• Meilenstein: 3.0.3 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 3

Details

sdl2-client does not free city_map_canvas on exit. Should be fixed just so that it won't show up in valgrind reports any more (possibly causing people to investigate the situation over and over)

Ticket-Verlauf (3/6 Historien)

2022-06-05 06:26 Aktualisiert von: cazfi

• New Ticket "sdl2: city_map_canvas not freed on client exit" created

2022-06-12 04:16 Aktualisiert von: cazfi

• File 0039-sdl2-Free-city_map_canvas-on-exit.patch (File ID: 9463) is attached

2022-06-12 04:16 Aktualisiert von: cazfi

• File 0018-sdl2-Free-city_map_canvas-on-exit.patch (File ID: 9464) is attached

2022-06-12 04:16 Aktualisiert von: cazfi

• File 0009-sdl-2-Free-city_map_canvas-on-exit.patch (File ID: 9465) is attached

2022-06-12 04:19 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar

Reply To cazfi

Should be fixed just so that it won't show up in valgrind reports any more

These fixes actually handle also such an issue that the city_map_canvas pointer was not initialized, and if it happened to be non-NULL it was assumed to contain a valid value to free() before reallocation. To fix that more serious aspect made also S2_6 version.

2022-06-18 04:56 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt