create_command_newcomer() may break if there's no dead players

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Fehler
• Status: Geschlossen
• Komponente: Server
• Meilenstein: 3.0.2 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

create_command_newcomer() may try to free player slot for the new player by removing dead player(s). This works correctly only when there's exactly one dead player. If there's none -> it still continues as if it now would have a free slot. If there's more than one -> the message about "replacing dead player" has a wrong name (last of the freed dead players, while it will replace the first one).

Ticket-Verlauf (3/6 Historien)

2022-05-02 08:13 Aktualisiert von: cazfi

• New Ticket "create_command_newcomer() may break if there's no dead players" created

2022-05-02 08:28 Aktualisiert von: cazfi

• Meilenstein Update from (Keine) to 3.0.2 (closed)

2022-05-03 04:11 Aktualisiert von: cazfi

• File 0049-create_command_newcomer-Do-not-assume-one-dead-playe.patch (File ID: 9142) is attached

2022-05-03 04:11 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted

Kommentar

Will push even to S2_6

2022-05-12 09:43 Aktualisiert von: cazfi

Kommentar

Reply To cazfi

Will push even to S2_6

No, I won't. This introduces a new string, and we don't assume translators to touch S2_6 any more.

2022-05-12 10:00 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt