Government change at turn change

• Auswertung: cazfi
• Verantwortlicher: cazfi
• Typ: Patches
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.2.0
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

From my comment in #41813:

"

ihnatus:
Player that has Statue of Liberty or just have finished revolen this turn can change governments for free and exploit it a lot, so let some bonuses be available only when the dust settles

I think that for this the engine should enforce some rules, and not leave it to ruleset to plug every possible exploit. This could work similar to multiplier changes that can be chosen during the turn freely, but are activated only at turn change (it has two variables; one that is the really active value, and second that tells what value user wants to activate in the next turn change)"

Ticket-Verlauf (3/5 Historien)

2022-01-12 02:16 Aktualisiert von: cazfi

• New Ticket "Government change at turn change" created

2022-05-13 19:05 Aktualisiert von: cazfi

Kommentar

Some users might not like that they lose the ability to adjust their nation based on the new government before turn change. Especially in the single-player where the old behavior causes no problems at all. Should we make it user choice which model they want (server setting)?

2022-05-14 12:56 Aktualisiert von: cazfi

• File 0043-Delay-government-change-to-the-end-of-phase.patch (File ID: 9229) is attached

2022-05-14 12:59 Aktualisiert von: cazfi

• Verantwortlicher Update from (Keine) to cazfi
• Lösung Update from Keine to Accepted
• Meilenstein Update from (Keine) to 3.2.0

Kommentar

Simple patch attached. The relatively high risk of introducing bugs with this is mainly due to side-effects of government_change() - it might not be a good idea to do those things in the new location in the middle of end-phase handling.

2022-05-22 16:15 Aktualisiert von: cazfi

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt