action_prob_pre_action_dice_roll() checking action possibility for wrong player

• Auswertung: cazfi
• Verantwortlicher: kvilhaugsvik
• Typ: Fehler
• Status: Geschlossen
• Komponente: General
• Meilenstein: 3.1.0 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

It seems wrong to me that action_prob_pre_action_dice_roll() checks "is_effect_val_known(EFT_ACTION_ODDS_PCT, act_player, tgt_player, tgt_player, ...". If I understand the functions right, the first player argument 'act_player' is who gets the information. Second and third ones are the the parties of the incident. So the call is like 'tgt_player' attacking 'tgt_player'. Should be 'act_player' attacking 'tgt_player', I think.

Ticket-Verlauf (3/5 Historien)

2021-11-06 22:05 Aktualisiert von: cazfi

• New Ticket "action_prob_pre_action_dice_roll() checking action possibility for wrong player" created

2021-11-07 00:06 Aktualisiert von: kvilhaugsvik

Kommentar

I agree that it looks that way. I have sent the author of that code an email to check if we have missed something.

(Edited, 2021-11-07 00:07 Aktualisiert von: kvilhaugsvik)

2021-11-08 15:39 Aktualisiert von: kvilhaugsvik

• File 0001-Check-effect-value-known-for-the-correct-player.patch (File ID: 7909) is attached

2021-11-08 15:41 Aktualisiert von: kvilhaugsvik

• Verantwortlicher Update from (Keine) to kvilhaugsvik
• Lösung Update from Keine to Accepted
• Meilenstein Update from (Keine) to 3.1.0 (closed)

Kommentar

Reply To kvilhaugsvik

I have sent the author of that code an email to check if we have missed something.

We didn't miss something.

2021-11-12 18:34 Aktualisiert von: kvilhaugsvik

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt