Ticket #42204

capability.c function headers to say 'TRUE' instead of 'true'

Eröffnet am: 2021-05-09 20:54 Letztes Update: 2022-07-27 07:24

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Gefixt
Datei:
1

Details

When referring to value of type bool, capability.c function headers should say 'TRUE' instead of 'true'

Ticket-Verlauf (3/6 Historien)

2021-05-09 20:54 Aktualisiert von: cazfi
  • New Ticket "capability.c function headers to say 'TRUE' instead of 'true'" created
2022-07-19 05:55 Aktualisiert von: dark-ether
Kommentar

i was looking on old tickets to see if any interested me and this seemed too easy to just leave undone.

I assume you did this ticket to generate discussion, in my opinion we should be consistent with style and leave all function headers in all caps when they refer to the macros

2022-07-19 15:44 Aktualisiert von: cazfi
Kommentar

Reply To dark-ether

in my opinion we should be consistent with style and leave all function headers in all caps when they refer to the macros

It's not only a style issue, but the fact that 'TRUE' (the macro) is not the same thing as boolean concept (or C++ / newer C boolean value) 'true'.

Typically I open this kind of tickets when I'm working on something else that I don't want to interrupt (maybe also having modifications for that work in my source tree) and don't want to forget what I've noticed.

Likely there's similar issues in other headers too.

2022-07-25 09:30 Aktualisiert von: cazfi
  • Verantwortlicher Update from (Keine) to cazfi
  • Lösung Update from Keine to Accepted
  • Meilenstein Update from (Keine) to 3.1.0 (closed)
Kommentar

The patch does not apply to S3_0. Just targeting the ticket to S3_1 instead of waiting for separate S3_0 patch.

2022-07-27 07:24 Aktualisiert von: cazfi
  • Status Update from Offen to Geschlossen
  • Lösung Update from Accepted to Gefixt

Dateianhangliste

Bearbeiten

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Anmelden