Ticket #41799

CI: run make distcheck

Eröffnet am: 2021-03-17 03:43 Letztes Update: 2021-03-19 21:10

Auswertung:
Verantwortlicher:
Typ:
Status:
Geschlossen
Komponente:
Meilenstein:
Priorität:
5 - Mittel
Schweregrad:
5 - Mittel
Lösung:
Accepted
Datei:
2

Details

See #41756

Ticket-Verlauf (3/9 Historien)

2021-03-17 03:43 Aktualisiert von: kvilhaugsvik
  • New Ticket "CI: run make distcheck" created
2021-03-17 16:42 Aktualisiert von: kvilhaugsvik
  • Lösung Update from Keine to Accepted
2021-03-17 19:55 Aktualisiert von: cazfi
Kommentar

There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.

2021-03-18 02:29 Aktualisiert von: kvilhaugsvik
Kommentar

Reply To cazfi

There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.

Yes. Running it separately gives us the message that dist was OK if the failure comes later in the distcheck part. Would you prefer that I remove those 3 lines?

2021-03-18 02:39 Aktualisiert von: cazfi
Kommentar

Reply To kvilhaugsvik

Reply To cazfi

There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.

Yes. Running it separately gives us the message that dist was OK if the failure comes later in the distcheck part. Would you prefer that I remove those 3 lines?

I'm not sure. You have a point, but is it worth having every CI build to make dist twice? No matter which part fails, we would start investigating it, and would quickly see what is the failing part ourselves.

2021-03-18 02:46 Aktualisiert von: kvilhaugsvik
Kommentar

Reply To cazfi

Reply To kvilhaugsvik

Reply To cazfi

There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.

Yes. Running it separately gives us the message that dist was OK if the failure comes later in the distcheck part. Would you prefer that I remove those 3 lines?

I'm not sure. You have a point, but is it worth having every CI build to make dist twice?

I was assuming that it wouldn't run twice as that target already had run. (I should have looked for a file named "dist" rather than just assuming)

(Edited, 2021-03-18 02:53 Aktualisiert von: kvilhaugsvik)
2021-03-19 21:10 Aktualisiert von: kvilhaugsvik
  • Status Update from Offen to Geschlossen

Bearbeiten

Please login to add comment to this ticket » Anmelden