CI: run make distcheck
There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.
Reply To cazfi
There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.
Yes. Running it separately gives us the message that dist was OK if the failure comes later in the distcheck part. Would you prefer that I remove those 3 lines?
Reply To kvilhaugsvik
Reply To cazfi
There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.
Yes. Running it separately gives us the message that dist was OK if the failure comes later in the distcheck part. Would you prefer that I remove those 3 lines?
I'm not sure. You have a point, but is it worth having every CI build to make dist twice? No matter which part fails, we would start investigating it, and would quickly see what is the failing part ourselves.
Reply To cazfi
Reply To kvilhaugsvik
Reply To cazfi
There's no need to run 'make dist' and 'make distcheck' separately. Former is subset of latter.
Yes. Running it separately gives us the message that dist was OK if the failure comes later in the distcheck part. Would you prefer that I remove those 3 lines?
I'm not sure. You have a point, but is it worth having every CI build to make dist twice?
I was assuming that it wouldn't run twice as that target already had run. (I should have looked for a file named "dist" rather than just assuming)
See #41756