CI: detect broken ruledit comments

• Auswertung: kvilhaugsvik
• Verantwortlicher: kvilhaugsvik
• Typ: Patches
• Status: Geschlossen
• Komponente: CI
• Meilenstein: 3.1.0 (closed)
• Priorität: 5 - Mittel
• Schweregrad: 5 - Mittel
• Lösung: Gefixt
• Datei: 1

Details

So #41631 won't happen again.

Ticket-Verlauf (3/7 Historien)

2021-02-23 07:47 Aktualisiert von: kvilhaugsvik

• New Ticket "CI: detect broken ruledit comments" created

2021-02-23 08:05 Aktualisiert von: kvilhaugsvik

Kommentar

Should ruledit's option Fatal have caught the log_error() call via fatal_assertions?

2021-02-24 22:14 Aktualisiert von: kvilhaugsvik

Kommentar

Reply To kvilhaugsvik

Should ruledit's option Fatal have caught the log_error() call via fatal_assertions?

If not I could extend it to directly exit with a non success exits status when --Fatal (or a new command line option) is specified. That would give us CI coverage.

2021-03-23 07:54 Aktualisiert von: cazfi

Kommentar

log_error() is not fatal nor assertion.

2021-03-23 09:30 Aktualisiert von: kvilhaugsvik

• File 0009-ruleup-set-exit-status-based-on-what-happened.patch (File ID: 6316) is attached

2021-03-23 09:31 Aktualisiert von: kvilhaugsvik

• Lösung Update from Keine to Accepted

Kommentar

Reply To cazfi

log_error() is not fatal nor assertion.

Thank you for the clarification, Marko!

2021-03-25 17:47 Aktualisiert von: kvilhaugsvik

• Status Update from Offen to Geschlossen
• Lösung Update from Accepted to Gefixt