#47455: sdl2: Citydfg unit orders menu never shown Open Date: 2023-02-20 00:23 Last Update: 2023-02-20 00:23 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/47455 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47455 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-02-20 00:23 Updated by: cazfi * New Ticket "sdl2: Citydfg unit orders menu never shown" created --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: 3.0.7 Component: SDL2-client Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: sdl2-client units_orders_city_dlg_callback() enters block that is supposed to open orders menu only for PRESSED_EVENTs. Early in the block is another check for PRESSED_EVENT that cause city dialog to close with the unit in focus on main map. As event can't be simultaneously both PRESSED_EVENT and not-PRESSED_EVENT, the orders menu part of the code block is dead code. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/47455 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47455