#45542: Avoid advance_count() calls in advance_index_iterate() within outer iteration
Open Date: 2022-09-01 04:33
Last Update: 2022-09-24 09:34
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45542
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45542
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-09-24 09:34 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Patches
Status: Closed
Priority: 5 - Medium
MileStone: 3.2.0
Component: General
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
Something that came out while looking at #45541: advance_count() in advance_index_iterate() is often called repeatedly as advance_index_iterate() itself is used repeatedly.
Changing that would both be a minor optimization (removal of the funcfion call overhead) and make compiler and other tools better able to analyze the code (now they have to be prepared to the possibility that consequtive advance_count() calls return different results)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45542
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45542