#45845: Adjust city name in network protocol
Open Date: 2022-10-12 20:50
Last Update: 2022-10-26 19:54
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45845
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45845
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-26 19:54 Updated by: cazfi
* Milestone Update from S3_1 npf to S3_2 npf
Comment:
Network protocol is already smart enough to send city name as NULL-terminated string, and not a fixed size array. So nothing to do for that.
Second thing considered was that city name could be moved to a packet of its own to avoid too big PACKET_CITY_INFO. For that part, there's a couple of much worse offenders -> will open a new tickets about those.
City name as part of PACKET_CITY_INFO isn't problem in S3_1. Let's recheck the situation before 3.2, especially if MAX_LEN_CITYNAME gets increased -> retargeting to S3_2-npf
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: S3_2 npf
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Likely the network protocol could be made better concerning city names (in city_info etc), esp. after #45786 and #45844
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45845
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45845