#45770: Qt: Most mr_menu::menus_sensitive() pterrain assignments unused
Open Date: 2022-10-05 02:44
Last Update: 2022-10-05 02:46
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45770
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45770
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-05 02:46 Updated by: cazfi
* Milestone Update from (None) to 3.0.5
Comment:
Reply To cazfi
Transform has some duplicate code lines
That's also in S3_0.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 3.0.5
Component: Qt-client
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
mr_menu::menus_sensitive() assigns pterrain for handling some activities where it's not really used. For Irrigate and Mine this likely just a leftover from the time they had the terrain changing form included (i.e only S3_1 and master affected). Transform has some duplicate code lines - so that the first assignment gets overwritten by the latter.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45770
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45770