#45891: Ruledit: Counters count
Open Date: 2022-10-17 20:15
Last Update: 2022-11-30 22:24
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45891
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45891
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-11-30 22:24 Updated by: lachu
Comment:
Reply To cazfi
Reply To lachu
Only one think not clear to me is: ruledit_disabled . Why this is introduced?
It allows "removing" ruleset item without very complex rearrangements in the memory. That is; item in an array just gets marked as "ruledit_disabled" and later items in the array remain where they are, instead of all the later items moving to fill the hole. It would be practically impossible to update all the references to those later items.
Hi. Should I introduce ruledit_enable in counter's struct? I introduced routine to remove counter in #45892 and there is small amount of entries in counter's array. Also, we do not have to keep specialized counter array (for city' counter, for example), because for ruledit we do not need it - there is no gameplay active, so we not need cache or mateinformation for city generation purposes.
I think adding bool ruledit_enabled is not necessary for counters.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.2.0
Component: Ruledit and ruleup
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Ruledit should show number of counters in the ruleset in the statistics.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45891
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45891