#46029: Improve and split is_req_unchanging()
Open Date: 2022-11-03 00:10
Last Update: 2022-11-03 08:55
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/46029
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46029
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-11-03 08:55 Updated by: ihnatus
Comment:
Since we have a table of requirement testers now, can we put some other data on it? Just I am too thick to benchmark things. Currently, unchanging requirements follow one or more of rules:
Always unchanging
Unchanging if local range
Unchanging if not provided by ally
Once present, can't change
Surviving requirements can't change from present unless provided by an ally
The function is_req_unchanging() now looks only at requirement itself but we often can get more specific results looking also at the context (and often even without performance loss).
---------------------------------------------------------------------
Ticket Status:
Reporter: ihnatus
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 3.0.5
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Split from #45982 since it's a much wider problem. The "bug" part is, actually, terrain etc. "can't build" callbacks not called even if you provide a tile for testing; also, some requirements are not updated during development so some buildings are not shown on the full building list for creating a construction plan.
We should use more actual sense of the requirements in client, while AI (including human player advisors) should get a different function that also should be actualized where possible but hides things AI would be confused by. (Surely, such things are better to be reduced in the future.)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/46029
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46029