#44847: "Wanted to cancel treaty but was unable to."
Open Date: 2022-06-17 10:35
Last Update: 2022-06-17 21:56
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44847
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44847
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-17 21:56 Updated by: cazfi
Comment:
I can reproduce this (but it takes over ten hours to run the autogame from the beginning to the point where it fails)
It's likely that the senate is blocking the treaty cancellation. I see 3 potential reasons for that (3 different bugs?). The code block above the failing one is supposed to cause revolution in case senate of the current government would try to block the action. That's just assumed to success, but it can fail at least if the revolentype prevents a new revolution on the same turn previous one finished. Also, in master the government change is not instantaneous, but will only happen on turn change.
Then there's a chance that in order to go to war, multiple levels of treaties would need to be cancelled. That's known to be buggy, even by FIXME comment in handle_diplomacy_cancel_pact(). It's possible that senate is not supposed to block the action (and thus we didn't revolt) because "has_reason_to_cancel". However, as each step of the pact cancellations is handled separately, the "has_reason_to_cancel" is no longer TRUE when one treaty has already been cancelled, and then senate blocks the second step.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: (None)
Component: (None)
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
There's a couple of "Wanted to cancel treaty but was unable to." messages I've not seen before in S3_1 autogame set run (still in progress) log. Those are from running with the sandbox ruleset.
The codebase on this run was not from any exact git repo revision, but it has a couple of "future" patches in testing.
I'll try to reproduce that.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44847
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44847