[Freeciv-tickets] [freeciv] #44748: Define what is "Special" building genus

Zurück zum Archiv-Index
OSDN Ticket System norep****@osdn*****
Mon Jun 6 09:24:18 JST 2022


#44748: Define what is "Special" building genus

  Open Date: 2022-06-03 20:42
Last Update: 2022-06-06 03:24

URL for this Ticket:
    https://osdn.net//projects/freeciv/ticket/44748
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44748

---------------------------------------------------------------------

Last Changes/Comment on this Ticket:
2022-06-06 03:24 Updated by: cazfi

Comment:

Reply To alienvalkyrie

Note: Any actual action we take here (beyond maybe adding deprecation warnings) is almost certainly gonna change dff
Complicated if such a change classify as a bugfix (I think that's why ihnatus started with "Classified is a bug..."). Which is sometimes hairy to declare as we don't have much specification beyond what the code implements, and even if developers meant something else than what the code implements, we can't just break things for users who have interpreted code to be correct.

---------------------------------------------------------------------
Ticket Status:

      Reporter: ihnatus
         Owner: (None)
          Type: Bugs
        Status: Open
      Priority: 5 - Medium
     MileStone: 3.0.3
     Component: General
      Severity: 5 - Medium
    Resolution: None
---------------------------------------------------------------------

Ticket details:

Related to #44696.
Classified is a bug because some uses of it in loadable ruleset raise warnings, and errors are not known but possible. Originally, "Special" genus was used for spaceship parts, and for coinage that got its own genus in latest versions; these buildings are fixed to this genus in HRM824590 but not vice versa. These buildings are not built into improvements of a city and the code sometimes suggests that this genus can never, but effectively, it can. "Special" buildings with no mentioned special properties effectively work like normal improvements but can't be sold or lost on city conquest, have not checked sabotaging them; maybe supporting unsellable non-unique buildings is not a useless option though it could have been done in some better way.
So, we should agree on either preventing their non-standard use in rulesets (that potentially contradicts how spaceship effects work to the extent we can't call it the same dff any more) or specifying how it should be handled with emitting no warnings in possible cases and avoiding AI confusion where it's not too difficult.

-- 
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN

Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net

URL for this Ticket:
    https://osdn.net/projects/freeciv/ticket/44748
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44748



More information about the Freeciv-tickets mailing list
Zurück zum Archiv-Index